histogram: expose FindBucket in Histogram API
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to record observations into multiple histograms efficiently, it is helpful to be able to execute the `findBucket` call on the client-side and then use the bucket to update multiple histogram instances. This change makes `FindBucket` and `ObserveInternal` public and introduces the `HistogramInternal` interface to expose them since `Histogram` itself is implemented by many implementations we want to avoid modifying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to record observations into multiple histograms efficiently, it is helpful to be able to execute the
findBucketcall on the client-side and then use the bucket to update multiple histogram instances.This change makes
FindBucketandObserveInternalpublic and introduces theHistogramInternalinterface to expose them sinceHistogramitself is implemented by many implementations we want to avoid modifying.Part of cockroachdb/cockroach#138932
Part of cockroachdb/cockroach#133306